New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Allow single error messages in ValidationException::withMessages #21400

Merged
merged 1 commit into from Sep 26, 2017

Conversation

Projects
None yet
3 participants
@sebastiandedeyne
Contributor

sebastiandedeyne commented Sep 26, 2017

Allows this:

throw ValidationException::withMessages([
    'email' => 'This address is never allowed to be registered',
]);

Instead of always having to do this:

throw ValidationException::withMessages([
    'email' => ['This address is never allowed to be registered'],
]);
@themsaid

This comment has been minimized.

Show comment
Hide comment
@themsaid

themsaid Sep 26, 2017

Member

@sebastiandedeyne whoops, Travis failing.

Member

themsaid commented Sep 26, 2017

@sebastiandedeyne whoops, Travis failing.

@taylorotwell taylorotwell merged commit 08fa1e3 into laravel:5.5 Sep 26, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
@sebastiandedeyne

This comment has been minimized.

Show comment
Hide comment
@sebastiandedeyne

sebastiandedeyne Sep 26, 2017

Contributor

Hmm doesn't seem to be related with this change:

$ phpenv config-rm xdebug.ini || true
File xdebug.ini removed from /home/travis/.phpenv/versions/7.1/etc/conf.d.
$ echo "extension = memcached.so" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini
$ printf "\n" | pecl install -f redis
Package "redis" does not have REST info xml available
install failed

Just merged so guess it's okay 😄

Contributor

sebastiandedeyne commented Sep 26, 2017

Hmm doesn't seem to be related with this change:

$ phpenv config-rm xdebug.ini || true
File xdebug.ini removed from /home/travis/.phpenv/versions/7.1/etc/conf.d.
$ echo "extension = memcached.so" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini
$ printf "\n" | pecl install -f redis
Package "redis" does not have REST info xml available
install failed

Just merged so guess it's okay 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment