New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Add make command for custom exceptions #21483

Merged
merged 2 commits into from Oct 3, 2017

Conversation

Projects
None yet
4 participants
@Lloople
Contributor

Lloople commented Oct 1, 2017

Added the ability to create custom exceptions with php artisan make:exception. This command will create the Exception inside the Exceptions namespace of the app.

You can also use the flags --render and --report to generate the methods.

@GrahamCampbell GrahamCampbell changed the title from Add make command for custom exceptions to [5.5] Add make command for custom exceptions Oct 1, 2017

@GrahamCampbell

This comment has been minimized.

Show comment
Hide comment
@GrahamCampbell

GrahamCampbell Oct 1, 2017

Member

I think this is maybe overkill?

Member

GrahamCampbell commented Oct 1, 2017

I think this is maybe overkill?

@Lloople

This comment has been minimized.

Show comment
Hide comment
@Lloople

Lloople Oct 1, 2017

Contributor

Why is that? I use custom exception a lot since the framework allows us to have the render method. I ended up duplicating an existing one or creating it manually, which I could do also with Controllers but we have a command for that.

Sorry for bad english

Contributor

Lloople commented Oct 1, 2017

Why is that? I use custom exception a lot since the framework allows us to have the render method. I ended up duplicating an existing one or creating it manually, which I could do also with Controllers but we have a command for that.

Sorry for bad english

@taylorotwell taylorotwell merged commit 46529ae into laravel:5.5 Oct 3, 2017

1 of 2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has failed - 1 file needs addressing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment