New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Allow marking notifications as unread #21497

Merged
merged 2 commits into from Oct 2, 2017

Conversation

Projects
None yet
3 participants
@shadoWalker89
Contributor

shadoWalker89 commented Oct 2, 2017

I have a notification area i show notifications to the users.

Some of my users need to mark notifications as unread to return for them later.

I think this is a very common thing, as the vast majority of email services allow for email to be marked as unread, also notifications in most of the websites are allowed to be marked as unread.

@shadoWalker89 shadoWalker89 changed the title from Allow marking notifications as unread to [5.5] Allow marking notifications as unread Oct 2, 2017

@aliusa

This comment has been minimized.

Show comment
Hide comment
@aliusa

aliusa Oct 2, 2017

Please add tests.

aliusa commented Oct 2, 2017

Please add tests.

@taylorotwell taylorotwell merged commit 5c77eac into laravel:5.5 Oct 2, 2017

1 check passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details

edsamonte added a commit to edsamonte/framework that referenced this pull request Oct 6, 2017

Merge branch 'upstream/5.5' into 5.5
* upstream/5.5:
  Added missing postgres inet operators. (laravel#21518)
  tag v5.5.14 release notes
  version
  update v5.5 changelog
  Apply fixes from StyleCI (laravel#21514)
  formatting
  Remove unnecessary else statement
  add mapToDictionary tests
  rename method dictionary -> mapToDictionary; avoid pre-pr regression
  formatting
  formatting
  [5.5] Allow marking notifications as unread (laravel#21497)
  methods on facade are static (laravel#21501)
  StyleCI fixes
  Add ability to pass callback to whenLoaded Resource method
  Fix User model typehints & `$user` variable duplicates in Policy stub;
  Add make command for custom exceptions
  add buildToDictionary

@shadoWalker89 shadoWalker89 deleted the shadoWalker89:mark_unread branch Oct 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment