[5.5] Allow marking notifications as unread #21497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadoWalker89
force-pushed
the
mark_unread
branch
from
f0fcef3
to
080ee73
Compare
shadoWalker89
changed the title
|
Please add tests. |
edmandiesamonte
added a commit
to edmandiesamonte/framework
that referenced
this pull request
Oct 6, 2017
* upstream/5.5: Added missing postgres inet operators. (laravel#21518) tag v5.5.14 release notes version update v5.5 changelog Apply fixes from StyleCI (laravel#21514) formatting Remove unnecessary else statement add mapToDictionary tests rename method dictionary -> mapToDictionary; avoid pre-pr regression formatting formatting [5.5] Allow marking notifications as unread (laravel#21497) methods on facade are static (laravel#21501) StyleCI fixes Add ability to pass callback to whenLoaded Resource method Fix User model typehints & `$user` variable duplicates in Policy stub; Add make command for custom exceptions add buildToDictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a notification area i show notifications to the users.
Some of my users need to mark notifications as unread to return for them later.
I think this is a very common thing, as the vast majority of email services allow for email to be marked as unread, also notifications in most of the websites are allowed to be marked as unread.