Repository navigation
[5.6] Updated to use new release of cron-expression - #21637
Merged
taylorotwell merged 2 commits intoOct 13, 2017
Merged
Conversation
|
The |
Contributor
Author
|
Right, I mention that above. I don't know exactly what that test is doing in the first place (I don't use Laravel) so I'm not sure what the proper fix is. While I could just change the hash, I don't know that it's supposed to change. Any help would be appreciated with that test. |
Member
|
Thanks I'll take a look |
Contributor
Author
|
Thanks @taylorotwell ! |
Member
|
Fixed the test by applying the new mutex after the expression has changed. |
Member
|
Thanks |
dragonmantank
referenced
this pull request
in illuminate/console
Oct 22, 2017
* Updated to use new release of cron-expression * fix test
salmanarshad321
pushed a commit
to salmanarshad321/framework
that referenced
this pull request
Sep 23, 2026
* Updated to use new release of cron-expression * fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Laravel Framework to support the new 2.x branch of
cron-expression.I looked through the test set to fix what I could find that relies on the library, and the only test I could not fix was
Illuminate\Tests\Console\Scheduling\EventTest::testBuildCommand... I'm just not exactly sure how all that is managed, so the hash it generates is different than what the test expects. If I missed any other tests, let me know and I'll gladly update this PR. Most of the test changes are becausecron-expressionhas dropped support for the Year place.This is in response to mtdowling/cron-expression#153 and #19532. More detail on the package name change can be found at http://ctankersley.com/2017/10/12/cron-expression-update/