Skip to content

[5.6] Updated to use new release of cron-expression - #21637

Merged
taylorotwell merged 2 commits into
laravel:masterfrom
dragonmantank:update-cron-expression-library
Oct 13, 2017
Merged

taylorotwell merged 2 commits into
laravel:masterfrom
dragonmantank:update-cron-expression-library

Conversation

@dragonmantank

Copy link
Copy Markdown
Contributor

This updates the Laravel Framework to support the new 2.x branch of cron-expression.

I looked through the test set to fix what I could find that relies on the library, and the only test I could not fix was Illuminate\Tests\Console\Scheduling\EventTest::testBuildCommand ... I'm just not exactly sure how all that is managed, so the hash it generates is different than what the test expects. If I missed any other tests, let me know and I'll gladly update this PR. Most of the test changes are because cron-expression has dropped support for the Year place.

This is in response to mtdowling/cron-expression#153 and #19532. More detail on the package name change can be found at http://ctankersley.com/2017/10/12/cron-expression-update/

@Dylan-DPC-zz

Copy link
Copy Markdown

The Illuminate\Tests\Console\Scheduling\EventTest::testBuildCommand test is failing

@dragonmantank

Copy link
Copy Markdown
Contributor Author

Right, I mention that above. I don't know exactly what that test is doing in the first place (I don't use Laravel) so I'm not sure what the proper fix is. While I could just change the hash, I don't know that it's supposed to change. Any help would be appreciated with that test.

@taylorotwell

Copy link
Copy Markdown
Member

Thanks I'll take a look

@taylorotwell
taylorotwell requested a review from themsaid October 12, 2017 20:09
@dragonmantank

Copy link
Copy Markdown
Contributor Author

Thanks @taylorotwell !

@themsaid

Copy link
Copy Markdown
Member

Fixed the test by applying the new mutex after the expression has changed.

@taylorotwell
taylorotwell merged commit 07d160a into laravel:master Oct 13, 2017
@taylorotwell

Copy link
Copy Markdown
Member

Thanks

dragonmantank referenced this pull request in illuminate/console Oct 22, 2017
* Updated to use new release of cron-expression

*    fix test
salmanarshad321 pushed a commit to salmanarshad321/framework that referenced this pull request Sep 23, 2026
* Updated to use new release of cron-expression

*    fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants