Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Allow setting editor for Whoops #22350

Merged
merged 2 commits into from Dec 8, 2017
Merged

[5.5] Allow setting editor for Whoops #22350

merged 2 commits into from Dec 8, 2017

Conversation

m1guelpf
Copy link
Contributor

@m1guelpf m1guelpf commented Dec 7, 2017

Whoops allows defining an editor to open the file that caused the exception with it. This PR adds an option to set this.

Reference: Open Files In An Editor - Whoops.

:octocat:

@laurencei
Copy link
Contributor

laurencei commented Dec 7, 2017

This has come up before.

You can just edit the app\Exceptions\Handler.php yourself:

public function whoopsHandler()
{
    $handler = parent::whoopsHandler();
    $handler->setEditor(config('app.debug_editor'));
    return $handler;
}

@tillkruss tillkruss changed the title Allow setting editor for Whoops [5.5] Allow setting editor for Whoops Dec 7, 2017
@taylorotwell taylorotwell merged commit e9aaa4e into laravel:5.5 Dec 8, 2017
@m1guelpf m1guelpf deleted the patch-1 branch December 8, 2017 14:45
@antonkomarev
Copy link
Contributor

Thanks for sharing this!

yajra added a commit to yajra/laravel that referenced this pull request Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants