Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.6] Operator optional! #22378

Merged
merged 3 commits into from
Dec 10, 2017
Merged

[5.6] Operator optional! #22378

merged 3 commits into from
Dec 10, 2017

Conversation

emtudo
Copy link
Contributor

@emtudo emtudo commented Dec 10, 2017

Sending to branch master as recommended #22361

@GrahamCampbell GrahamCampbell changed the title Operator optional! [5.6] Operator optional! Dec 10, 2017
@sisve
Copy link
Contributor

sisve commented Dec 10, 2017

Could you also add some tests to this functionality?

@emtudo
Copy link
Contributor Author

emtudo commented Dec 10, 2017

@sisve Done!

@antonkomarev
Copy link
Contributor

antonkomarev commented Dec 10, 2017 •
edited
Loading

Should we change orWhereTime signature too?

From:

public function orWhereTime($column, $operator, $value)

To:

public function orWhereTime($column, $operator, $value = null)

@emtudo
Copy link
Contributor Author

emtudo commented Dec 10, 2017

@a-komarev
done!

@taylorotwell taylorotwell merged commit c614475 into laravel:master Dec 10, 2017
@taylorotwell
Copy link
Member

@themsaid can you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emtudo @sisve @antonkomarev @taylorotwell