[5.6] Add $outputBuffer argument #22463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changing method signatures is a breaking change and should target the next Laravel release; in this case the 5.6 release in the master branch. |
GrahamCampbell
changed the title
GrahamCampbell
changed the title
|
looks like this is in reference to 5e5be5c crazy it took this long to pop up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extend Illuminate\Console\Application
php will report
Declaration of Recca0120\Terminal\Application::call($command, array $parameters = Array) must be compatible with Illuminate\Console\Application::call($command, array $parameters = Array, $outputBuffer = NULL)