[5.6] Fix expectsJson returning true when explicitly expecting other content type#22506
Merged
taylorotwell merged 2 commits intolaravel:masterfrom Dec 29, 2017
Merged
Conversation
Member
|
What if no Accepts is set at all for an AJAX request? |
Contributor
Author
|
@taylorotwell Would you like to change this behavior and treat it as expecting any type? It makes sense, following the logic of the function, to consider that an |
| * | ||
| * @return bool | ||
| */ | ||
| public function wantsAnyContentType() |
Collaborator
There was a problem hiding this comment.
Maybe a better name for this would be acceptsAnyContentType.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
$request->expectsJson()was returningtruewhen explicitly expecting other content type.Targeting
masterdue the risk of a breaking change.See the original PR #22459