Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Updated mass assignment exception wording #22565

Merged
merged 1 commit into from
Dec 29, 2017
Merged

[5.6] Updated mass assignment exception wording #22565

merged 1 commit into from
Dec 29, 2017

Conversation

ok200paul
Copy link
Contributor

@ok200paul ok200paul commented Dec 29, 2017

Updated mass assignment exception wording for clarity; nominating the key alone is a little vague.

I was finding when running firstOrCreate() on a model where I neglected to update the $fillable array was returning an exception with the first key name in it each time. The fix itself was obvious and simple (ie updating $fillable), but I thought adding a couple of breadcrumbs for folks new to Laravel might help.

@GrahamCampbell GrahamCampbell changed the base branch from 5.5 to master December 29, 2017 12:43
@GrahamCampbell GrahamCampbell changed the title Updated mass assignment exception wording for clarity [5.6] Updated mass assignment exception wording Dec 29, 2017
@taylorotwell taylorotwell merged commit c7f14fb into laravel:master Dec 29, 2017
@deleugpn
Copy link
Contributor

Maybe this should be inside the exception class itself?

@ok200paul ok200paul deleted the clarify-mass-assignment-exception-wording branch January 1, 2018 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants