Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Added getDefaultParameters() to UrlGenerator #22572

Merged
merged 4 commits into from Jan 3, 2018

Conversation

shpontex
Copy link
Contributor

@shpontex shpontex commented Dec 30, 2017

add function to get the default parameters
very useful if you want to set the default parameters inside javascript code

add function to get the default parameters
very useful if you want to set the default parameters inside javascript code like (Ziggy)
change for styleCI
@@ -477,6 +477,16 @@ public function defaults(array $defaults)
$this->routeUrl()->defaults($defaults);
}

/**
* get the default named parameters used by the URL generator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capital G?

@GrahamCampbell GrahamCampbell changed the title Update UrlGenerator.php [5.5] Update UrlGenerator.php Dec 30, 2017
@GrahamCampbell GrahamCampbell changed the title [5.5] Update UrlGenerator.php [5.5] Added getDefaultParameters() to UrlGenerator Dec 30, 2017
@sisve
Copy link
Contributor

sisve commented Dec 30, 2017

No tests?

@taylorotwell taylorotwell merged commit 8c6b80e into laravel:5.5 Jan 3, 2018
BenCavens pushed a commit to BenCavens/framework that referenced this pull request Jan 5, 2018
* Update UrlGenerator.php

add function to get the default parameters
very useful if you want to set the default parameters inside javascript code like (Ziggy)

* Update UrlGenerator.php

change for styleCI

* Fixed typos

* Removed extra space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants