Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Make HasAttributes::getDateFormat public #22618

Merged
merged 1 commit into from Jan 2, 2018
Merged

[5.6] Make HasAttributes::getDateFormat public #22618

merged 1 commit into from Jan 2, 2018

Conversation

Mechazawa
Copy link
Contributor

It doesn't really make sense to make the getter protected function if the setter is public.

It doesn't really make sense to make the getter protected function if the setter is public.
@GrahamCampbell GrahamCampbell changed the title Make HasAttributes::getDateFormat public [5.6] Make HasAttributes::getDateFormat public Jan 2, 2018
@GrahamCampbell GrahamCampbell changed the base branch from 5.5 to 5.6 January 2, 2018 16:04
@taylorotwell taylorotwell merged commit 31a183f into laravel:5.6 Jan 2, 2018
@Mechazawa Mechazawa deleted the patch-1 branch January 3, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants