Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Enable developer to use --realpath option to migration commands #22852

Merged
merged 3 commits into from
Jan 23, 2018

Conversation

crynobone
Copy link
Member

This would indicate given path should be translated to realpath instead
of relative to Laravel base path.

Benefits

You can use php artisan migrate --path=./tests/migrations --realpath when running integration testing on Laravel or 3rd party packages (via Testbench) without adding extra dependencies.

This would indicate given path should be translated to realpath instead
of relative to Laravel base path.

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone added a commit to orchestral/testbench-core that referenced this pull request Jan 19, 2018
This depends on laravel/framework#22852 to be merged.

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@taylorotwell
Copy link
Member

Do we ever actually run the realpath PHP function on the given string if the realpath option is specified?

@crynobone
Copy link
Member Author

Do we ever actually run the realpath PHP function on the given string if the realpath option is specified?

Based on Testbench usage example user would run realpath() as a parameters but should be possible to check it ourselves, if that's preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants