[5.7] Detect connection errors also #22905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following a discussion on larachat.slack.com (with @36864), I am planning to implement a test for this, but I will need to do some careful thinking about how to do it. Essentially, I will need to null the PDO object at the point of being about to beginTransaction() on it... |
tillkruss
changed the title
tillkruss
changed the title
|
5.6 is probably a better target for this? |
|
Please re-send to 5.6 branch. |
|
Sorry for the delay - now re-sent to 5.6 in #22948 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had an issue where a project has dropped a database connection and thrown a
FatalThrowableError. Looking at thecreateTransaction()function inhttps://github.com/laravel/framework/blob/5.5/src/Illuminate/Database/Concerns/ManagesTransactions.phpandsrc/Illuminate/Database/DetectsLostConnections.php, this only detects instances of theExceptionclass.I was able to resolve this issue in my project by changing the functions concerned to accept an instance of
Throwableinstead ofException, so this is a Pull Request implementing those changes.It's my first PR on a big project though, so I would appreciate any feedback :)