[5.6] Allows array or multiple params for hasAny helper - #22952
Merged
Conversation
Contributor
|
Thanks for doing that |
Contributor
|
This merge worries me extremely. We clearly showed, in the previous PR, that this change of logic changes/removes existing functionality. WHAT will it break? What syntax, and how has it been documented in the upgrade guide? How will I'm worried that this will only show up as an entry in the changelog saying "Allows array or multiple params for hasAny helper", but we already allowed arrays and multiple parameters before this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmission of #22919 to 5.6 branch