Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Allows array or multiple params for hasAny helper #22952

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

themsaid
Copy link
Member

Resubmission of #22919 to 5.6 branch

@bbashy
Copy link
Contributor

bbashy commented Jan 29, 2018

Thanks for doing that

@taylorotwell taylorotwell merged commit d93d0fa into laravel:5.6 Jan 29, 2018
@sisve
Copy link
Contributor

sisve commented Jan 30, 2018

This merge worries me extremely. We clearly showed, in the previous PR, that this change of logic changes/removes existing functionality. WHAT will it break? What syntax, and how has it been documented in the upgrade guide? How will $request->hasAny(['a', 'b']) change between Laravel 5.5 and Laravel 5.6?

I'm worried that this will only show up as an entry in the changelog saying "Allows array or multiple params for hasAny helper", but we already allowed arrays and multiple parameters before this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants