Skip to content

[5.6] PHPUnit 7#23005

Merged
taylorotwell merged 1 commit into
laravel:5.6from
carusogabriel:phpunit-7
Feb 2, 2018
Merged

[5.6] PHPUnit 7#23005
taylorotwell merged 1 commit into
laravel:5.6from
carusogabriel:phpunit-7

Conversation

@carusogabriel

Copy link
Copy Markdown
Contributor

Following #22998 with green tests

@taylorotwell

Copy link
Copy Markdown
Member

@sisve can you describe in more detail your problems with the framework using PHPUnit 7 for its test and how exactly that affects package developers?

@sisve

sisve commented Feb 2, 2018

Copy link
Copy Markdown
Contributor

There wouldn't be any problems with this if we're still officially support phpunit 6 for package developers. I'm not sure that this would affect anything at all.

My questions in the previous PR was mostly why we should upgrade. What's in phpunit 7 that we need, and will it affect any package developers? Will we accept scalar typehints to other parts of the system after this PR?

Just say that we'll still support phpunit 6 for package developers so that it is known. It's not obvious after the previous discussions.

@taylorotwell

Copy link
Copy Markdown
Member

How package developers test their packages seems entirely orthogonal to what the framework itself uses unless I'm still missing something.

@taylorotwell taylorotwell merged commit b8b26c0 into laravel:5.6 Feb 2, 2018
@carusogabriel carusogabriel deleted the phpunit-7 branch February 2, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants