Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.6] Improve session errors assertions #23055

Merged
merged 1 commit into from
Feb 7, 2018
Merged

[5.6] Improve session errors assertions #23055

merged 1 commit into from
Feb 7, 2018

Commits on Feb 7, 2018

  1. Improve session errors assertions 

    In the previous implementation of `TestResponse::assertSessionHasErrors` i
found that was not possible to find errors that had an integer key.

This was happening because if the assertion detected that the key was an
integer, it was sending the error value to the `MessageBag::has` method,
which was incorrect because that method uses the key to determine if
there is any messages for it.
    @roberto-aguilar
    roberto-aguilar committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    9b0ad74 View commit details
    Browse the repository at this point in the history