Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Tightenco/Collect should not be replaced anymore #23147

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

antonioribeiro
Copy link
Contributor

It's now under on its own namespace to co-live with Illuminate\Collection. And this is preventing us to require it.

It's now under on its own namespace to co-live with Illuminate\Collection. And this is preventing us to require it.
@mattstauffer
Copy link
Contributor

👍 Thanks Antonio!

@GrahamCampbell GrahamCampbell changed the title Tightenco/Collect should not be replaced anymore [5.6] Tightenco/Collect should not be replaced anymore Feb 13, 2018
@crynobone
Copy link
Member

crynobone commented Feb 14, 2018

  1. Shouldn't we use "tighten/collect":"<5.6.0" since it still would conflict with versions before v5.6.0.
  2. PR to 5.5 as well?

@ronjunevaldoz
Copy link

I love this fixed thanks! @antonioribeiro

@mattstauffer
Copy link
Contributor

@crynobone Great question. I really wish we could backport the alias, because it's really not version specific. But you're right; older versions will still have this same issue.

And yah, I do think it should apply to multiple versions.

@antonioribeiro would you be up for making the requested changes?

@antonioribeiro
Copy link
Contributor Author

@mattstauffer, already done:

#23152 - 5.5
#23153 - 5.6

@crynobone, thank you.

@antonioribeiro
Copy link
Contributor Author

Note: the namespace change happened in tightenco/collect 5.5.33, that's why it's <5.5.33, after that there's no need to replace collect anymore.

@antonioribeiro antonioribeiro deleted the patch-7 branch February 14, 2018 02:45
@crynobone
Copy link
Member

@antonioribeiro One more thing, https://github.com/laravel/framework/blob/5.6/src/Illuminate/Support/composer.json#L24

@antonioribeiro
Copy link
Contributor Author

@antonioribeiro
Copy link
Contributor Author

Those are the correct PRs:

#23159
#23160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants