[5.6] Testable date validation rules when comparison has relative time

[derekmd]

Change requested by: #19520

I noticed this issue recently in a feature test hitting an API endpoint and doing a HTTP request assertion equivalent to:

// Now a past date.
Carbon::setTestNow('2018-02-01');

$v = validator(['starts_on' => '2018-02-02'], ['starts_on' => 'date|after:today']);

$this->assertTrue($v->passes());

Only starts_on values after 2018-02-19 would pass validation.

Date validation rule parameters containing relative time like 'today' or 'next monday' don't respect Carbon::setTestNow(). To get a date-adjusted value when these keywords are present in a date parameter, instantiate Carbon instead of DateTime or strtotime().

The previous date parameter behaviour is left as-is. Only when Carbon::hasTestNow() and Carbon::hasRelativeKeywords($value) are true will an attempt be made to parse the string for an adjusted date.

Workaround for Carbon 1.20 & 1.21

Given carbon\carbon dependency of ~1.20, this code:

Carbon::setTestNow(new Carbon('last week'));
Carbon::parse('today');

wasn't supported until 1.22 (pull request: briannesbitt/Carbon#634) released Jan 15, 2017. So a few Carbon constructor lines were needed in ValidatesAttributes to support today as a validated relative time keyword.

[taylorotwell]

I updated Carbon dependency on laravel/framework.

[derekmd]

Even better! The commit has been updated for just Carbon >= 1.22.

[taylorotwell]

Your method hasRelativeDateKeyword isn't really a good description of what's totally happening I don't think. It also has checks regarding if Carbon has a test date in place. It does a little more than it indicates by its name.

[derekmd]

I sat for an unreasonable amount of time trying to think of a good name and isTestingRelativeDateTime() is the best I can come up with.

[taylorotwell]

I think that makes sense.