Skip to content

[5.6] SFTP driver - #23308

Merged
taylorotwell merged 2 commits into
laravel:5.6from
mputkowski:patch-sftp
Feb 27, 2018
Merged

taylorotwell merged 2 commits into
laravel:5.6from
mputkowski:patch-sftp

Conversation

@mputkowski

Copy link
Copy Markdown
Contributor

This PR adds SFTP storage driver, it allows to SSH key based authentication. SFTP driver requires league/flysystem-sftp so it should be added to composer file as in case of AWS or Rackspace drivers.

Example config:

'sftp' => [
    'driver' => 'sftp',
    'host' => 'example.com',
    'username' => 'username',
    'password' => 'password',
    'privateKey' => '/path/to/privateKey',
],

@deleugpn

Copy link
Copy Markdown
Contributor

@sisve what's your take on composer changes on a point-release? You usually have some good crazy-case insight about bc changes.

@sisve

sisve commented Feb 27, 2018

Copy link
Copy Markdown
Contributor

I have been summoned! ;)

I see no issues with this. It's only a suggestion, and an opt-in feature. The potential for bc breaking changes is when you force a new dependency upon people, specially when such a dependency may be in conflict with existing code. This is not the case with this PR.

I guess my bitter self see the usual documentation problem in asking people that "yes, some versions of 5.6 supports SFTP, are you sure you are on the right one?". This is mostly a documentation issue where we need to be clear on what release contains this new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants