[5.6] SFTP driver - #23308
Merged
Merged
[5.6] SFTP driver#23308
Conversation
Contributor
|
@sisve what's your take on composer changes on a point-release? You usually have some good crazy-case insight about bc changes. |
Contributor
|
I have been summoned! ;) I see no issues with this. It's only a suggestion, and an opt-in feature. The potential for bc breaking changes is when you force a new dependency upon people, specially when such a dependency may be in conflict with existing code. This is not the case with this PR. I guess my bitter self see the usual documentation problem in asking people that "yes, some versions of 5.6 supports SFTP, are you sure you are on the right one?". This is mostly a documentation issue where we need to be clear on what release contains this new feature. |
This was referenced Feb 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds SFTP storage driver, it allows to SSH key based authentication. SFTP driver requires
league/flysystem-sftpso it should be added to composer file as in case of AWS or Rackspace drivers.Example config: