Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Fix whereTime method for PostgresGrammar with correct casting. #23323

Merged
merged 1 commit into from
Feb 27, 2018
Merged

[5.6] Fix whereTime method for PostgresGrammar with correct casting. #23323

merged 1 commit into from
Feb 27, 2018

Conversation

pinguinjkeke
Copy link
Contributor

@pinguinjkeke pinguinjkeke commented Feb 27, 2018

Similar as whereDate, whereTime should cast timestamp to time like created_at::time.

Currently ->whereTime() throws an SQL grammar error, so it doesn't break anything:

ERROR: syntax error at or near "time"

It's a bugfix. So I think it should be merged to current LTS 5.5 branch too, I think.

Link: https://www.postgresql.org/docs/9.6/static/functions-datetime.html

@sisve
Copy link
Contributor

sisve commented Feb 27, 2018

Could we get the PR for 5.5 reopened and merged too? #23318

@pinguinjkeke
Copy link
Contributor Author

@sisve yeah, it would be cool

@taylorotwell taylorotwell merged commit 65b6ad5 into laravel:5.6 Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants