Skip to content

[5.6] Added support for MySQL's "sounds like" operator - #23351

Merged
taylorotwell merged 2 commits into
laravel:5.6from
mgrinspan:mike-grinspan-patch-1
Mar 1, 2018
Merged

[5.6] Added support for MySQL's "sounds like" operator#23351
taylorotwell merged 2 commits into
laravel:5.6from
mgrinspan:mike-grinspan-patch-1

Conversation

@mgrinspan

Copy link
Copy Markdown
Contributor

No description provided.

@sisve

sisve commented Mar 1, 2018

Copy link
Copy Markdown
Contributor

You've forgot to attach any tests to this PR.

@mgrinspan

Copy link
Copy Markdown
Contributor Author

Better? I'm new to TDD.

@GrahamCampbell GrahamCampbell changed the title Added support for MySQL's "sounds like" operator [5.6] Added support for MySQL's "sounds like" operator Mar 1, 2018
@GrahamCampbell

Copy link
Copy Markdown
Collaborator

Better? I'm new to TDD.

Adding tests is not TDD. :)

@taylorotwell
taylorotwell merged commit 075ba07 into laravel:5.6 Mar 1, 2018
@chandrasbt

Copy link
Copy Markdown

Awesome addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants