Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Fix use of unique() #23432

Merged
merged 1 commit into from
Mar 7, 2018
Merged

[5.6] Fix use of unique() #23432

merged 1 commit into from
Mar 7, 2018

Conversation

adam1010
Copy link
Contributor

@adam1010 adam1010 commented Mar 7, 2018

*** URGENT ***

The unique() call must be on the keys collection, not on the data collection. Calling unique() on the data collection can result in missing data because unique() de-duplicates based on the VALUES.

adam1010 referenced this pull request Mar 7, 2018
@taylorotwell taylorotwell merged commit 7bd8c6e into laravel:5.6 Mar 7, 2018
@adam1010 adam1010 deleted the validate_fix branch March 8, 2018 00:58
@adam1010 adam1010 restored the validate_fix branch March 8, 2018 00:58
@adam1010 adam1010 deleted the validate_fix branch March 8, 2018 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants