[5.6] Improving asset loading #23479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
|
👍 for |
|
Yes, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fonts requested via the Google stylesheet take time to load and a fair amount of time to lookup the DNS. So prefetch the DNS for the font files.
The Google Stylesheet doesn't start downloading until it's
@importis discovered in app.css (see laravel/laravel#4603). Moving it to the HTML will make it load sooner. (Another option would just be to preload the Google Stylesheet from the HTML and leave the CSS reference in app.css)The Javascript should be placed higher so that it is discovered soon and can be downloaded as soon as the HTML parser finds it. If this Javascript is not critical to the page, we should add the
deferattribute should be used instead of moving the tag to the bottom of the page.