Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.6] Make Illuminate\View\View Macroable. #23787

Merged
merged 2 commits into from
Apr 3, 2018
Merged

[5.6] Make Illuminate\View\View Macroable. #23787

merged 2 commits into from
Apr 3, 2018

Conversation

DanielCoulbourne
Copy link
Contributor

Yet another Pull Request to add use Macroable to an Illuminate class 馃槝

@m1guelpf
Copy link
Contributor

m1guelpf commented Apr 2, 2018 •
edited
Loading

@DanielCoulbourne The View class already has a __call() method. You'd have to import __call as macroCall and manually call it at the __call() method.

@DanielCoulbourne
Copy link
Contributor Author

Good point @m1guelpf

@taylorotwell taylorotwell merged commit 42248fb into laravel:5.6 Apr 3, 2018
@DanielCoulbourne DanielCoulbourne deleted the make-view-macroable branch April 3, 2018 13:48
@GrahamCampbell GrahamCampbell changed the title Make Illuminate\View\View Macroable. [5.6] Make Illuminate\View\View Macroable. Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielCoulbourne @m1guelpf @taylorotwell