Skip to content

[5.6] Make Illuminate\View\View Macroable. - #23787

Merged
taylorotwell merged 2 commits into
laravel:5.6from
DanielCoulbourne:make-view-macroable
Apr 3, 2018
Merged

[5.6] Make Illuminate\View\View Macroable.#23787
taylorotwell merged 2 commits into
laravel:5.6from
DanielCoulbourne:make-view-macroable

Conversation

@DanielCoulbourne

Copy link
Copy Markdown
Contributor

Yet another Pull Request to add use Macroable to an Illuminate class 😘

@m1guelpf

m1guelpf commented Apr 2, 2018

Copy link
Copy Markdown
Contributor

@DanielCoulbourne The View class already has a __call() method. You'd have to import __call as macroCall and manually call it at the __call() method.

@DanielCoulbourne

Copy link
Copy Markdown
Contributor Author

Good point @m1guelpf

@taylorotwell
taylorotwell merged commit 42248fb into laravel:5.6 Apr 3, 2018
@DanielCoulbourne
DanielCoulbourne deleted the make-view-macroable branch April 3, 2018 13:48
@GrahamCampbell GrahamCampbell changed the title Make Illuminate\View\View Macroable. [5.6] Make Illuminate\View\View Macroable. Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants