[5.6] Add missing dependency on league/flysystem-cached-adapter #23815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
changed the title
|
This should surely be in suggest, not require. The subpackage dependency also needs to be updated. |
|
If you ever write unit tests to cover Illuminate\Filesystem\Cache I guess you'll need the parent class around. |
|
Doesn't mean it should go in require though. If that were the case, everything in suggest would be in require. |
|
The difference between this "suggestion" and all the others is that this is the only one that you have a class extending from. If you try to generate code coverage without this dependency this will be very obvious. |
|
Well, in that case, the suggest should be removed from the main composer.json. |
taylorotwell
pushed a commit
that referenced
this pull request
Apr 6, 2018
TBlindaruk
pushed a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
Apr 7, 2018
TBlindaruk
pushed a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
Apr 7, 2018
* Revert "Add missing dependency on league/flysystem-cached-adapter (laravel#23815)" This reverts commit d60b1c1. * Added to suggested deps * Removed duplicate * Sync with main composer.json * Added to require-dev
TBlindaruk
pushed a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
Apr 7, 2018
TBlindaruk
pushed a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
Apr 7, 2018
* Revert "Add missing dependency on league/flysystem-cached-adapter (laravel#23815)" This reverts commit d60b1c1. * Added to suggested deps * Removed duplicate * Sync with main composer.json * Added to require-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Illuminate\Filesystem\Cache extends League\Flysystem\Cached\Storage\AbstractCache which can only be found in the package added in this PR.
NOTE: As a side-effect this fixes phpunit's code coverage generation which was my original goal.