[5.6] Add helpers for subquery join clauses#23818
Merged
taylorotwell merged 2 commits intolaravel:5.6from Apr 17, 2018
staudenmeir:5.6
Merged
[5.6] Add helpers for subquery join clauses#23818taylorotwell merged 2 commits intolaravel:5.6from staudenmeir:5.6
taylorotwell merged 2 commits intolaravel:5.6from
staudenmeir:5.6
Conversation
Contributor
|
There are no tests that verify that it works to joinSub several times in one query. Can you add that? Something like |
Contributor
Author
|
@sisve I added a test with multiple subquery joins. |
Contributor
|
How do you feel about using |
Contributor
Author
|
@BrandonShar I chose the name to match the existing |
Contributor
|
ah, that makes sense; wasn't familiar with those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
joinSub(),leftJoinSub()andrightJoinSub()to the query builder. The goal is to make subquery joins easier.At the moment subquery joins are possible using raw SQL:
That's ok for simple subqueries but gets a bit tedious if the subquery has bindings:
With the new helpers users can create subquery joins using raw SQL, a closure or a query builder: