[5.6] Add unset event dispatcher for connections #23832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
added a commit
to mfn/laravel-framework
that referenced
this pull request
Apr 11, 2020
This follows commit deafaa7 which already added this for RefreshDatabase. It's for the exact same reason as outlined in laravel#23832 : > This is motivated by the fact that in tests, when using the RefreshDatabase trait, transactions events are dispatched and may interfer with the application testing itself when it relies on events like these ( for further info, see laravel/ideas#1094 ). As to not have custom handling of transaction events interfere with the test suite itself, this simply disables this. Again, the same change was added to `RefreshDatabase` and is still present; this PR merely keeps the behaviour of them in sync in regards to the handling of events in transactions.
mfn
added a commit
to mfn/laravel-framework
that referenced
this pull request
Apr 12, 2020
This follows commit deafaa7 which already added this for RefreshDatabase. It's for the exact same reason as outlined in laravel#23832 : > This is motivated by the fact that in tests, when using the RefreshDatabase trait, transactions events are dispatched and may interfer with the application testing itself when it relies on events like these ( for further info, see laravel/ideas#1094 ). As to not have custom handling of transaction events interfere with the test suite itself, this simply disables this. Again, the same change was added to `RefreshDatabase` and is still present; this PR merely keeps the behaviour of them in sync in regards to the handling of events in transactions.
mfn
added a commit
to mfn/laravel-framework
that referenced
this pull request
Apr 12, 2020
This follows commit deafaa7 which already added this for RefreshDatabase. It's for the exact same reason as outlined in laravel#23832 : > This is motivated by the fact that in tests, when using the RefreshDatabase trait, transactions events are dispatched and may interfer with the application testing itself when it relies on events like these ( for further info, see laravel/ideas#1094 ). As to not have custom handling of transaction events interfere with the test suite itself, this simply disables this. Again, the same change was added to `RefreshDatabase` and is still present; this PR merely keeps the behaviour of them in sync in regards to the handling of events in transactions.
mfn
added a commit
to mfn/laravel-framework
that referenced
this pull request
Apr 12, 2020
This follows commit deafaa7 which already added this for RefreshDatabase. It's for the exact same reason as outlined in laravel#23832 : > This is motivated by the fact that in tests, when using the RefreshDatabase trait, transactions events are dispatched and may interfer with the application testing itself when it relies on events like these ( for further info, see laravel/ideas#1094 ). As to not have custom handling of transaction events interfere with the test suite itself, this simply disables this. Again, the same change was added to `RefreshDatabase` and is still present; this PR merely keeps the behaviour of them in sync in regards to the handling of events in transactions.
taylorotwell
pushed a commit
that referenced
this pull request
Apr 13, 2020
This follows commit deafaa7 which already added this for RefreshDatabase. It's for the exact same reason as outlined in #23832 : > This is motivated by the fact that in tests, when using the RefreshDatabase trait, transactions events are dispatched and may interfer with the application testing itself when it relies on events like these ( for further info, see laravel/ideas#1094 ). As to not have custom handling of transaction events interfere with the test suite itself, this simply disables this. Again, the same change was added to `RefreshDatabase` and is still present; this PR merely keeps the behaviour of them in sync in regards to the handling of events in transactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Laravel folks,
This Pull Request introduces the method unsetEventDispatcher for database connections.
This is motivated by the fact that in tests, when using the RefreshDatabase trait, transactions events are dispatched and may interfer with the application testing itself when it relies on events like these ( for further info, see laravel/ideas#1094).