[5.6] Allow to pass collection to validation rules #23875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerguslejko
changed the title
derekmd
reviewed
Apr 13, 2018
| * @return \Illuminate\Validation\Rules\In | ||
| */ | ||
| public static function in($values) | ||
| { | ||
| if ($values instanceof Collection) { |
There was a problem hiding this comment.
Maybe this should be generalized to Illuminate\Contracts\Support\Arrayable that Collection implements?
There was a problem hiding this comment.
We'd need to rewrite In and NotIn rules to accept array and collections then.
There was a problem hiding this comment.
Since Arrayable contains the toArray method all you would need to change was the condition I believe.
There was a problem hiding this comment.
Oh I see you point now. Sorry guys.
I'd argue that Arrayable is implemented by following classes: Request, LengthAwarePaginator, MessageBag, Fluent etc.
Still think that Collection & array are the way to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes necessary changes to allow for passing
Illuminate\Support\Collectionobjects toRule::in()andRule::notIn()methods.Thanks