[5.6] Allow for fluent registration of Route Resources to return a RouteCollection #23890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielCoulbourne
force-pushed
the
cause-resource-registrar-to-return-a-route-collection
branch
2 times, most recently
from
c46a456
to
368fd25
Compare
…g a RouteCollection.
DanielCoulbourne
force-pushed
the
cause-resource-registrar-to-return-a-route-collection
branch
from
368fd25
to
4ba828b
Compare
DanielCoulbourne
changed the title
GrahamCampbell
changed the title
All the methods you've changed are public. How is this not publicly accessible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for manual Registration of fluent Route Resource chains (which currently remain as a
PendingResourceRegistrationuntil destruction.Now upon registration they return a
RouteCollectionlike so:The
ResourceRegistrar::register()method previously returnedvoidbut based on the fact that it's not publicly accessible, I don't think this should be considered a breaking change 🤞While I recognize that this PR probably doesn't add a ton of value to the community at large, it won't make anyone's life worse and will make my life much nicer 😄