[5.6] i18n of the default notification email view#23903
[5.6] i18n of the default notification email view#23903taylorotwell merged 2 commits intolaravel:5.6from dakira:feature/i18n-notifications
Conversation
This uses json translations through the blade directive to allow easy translations of mail notifications.
|
Could you post the exact generated markdown before and after? |
|
@tillkruss do you have a hint on getting that? I couldn't find anything in the docs. Is the generated markdown saved in the storage folder somewhere? |
|
No, I'd probably send two emails and look that their raw data. I'm asking for this because whitespace is not ignored in that template and I don't know how the @lang is replaced exactly. |
|
There was one expected whitespace difference in the end because the original markdown has a hard linebreak. There's no difference in the html view of the mail but there is one in the text view. I pushed another commit to fix that. Here's a gist with before and after. For the test I created a de.json with a translation of "Hello!" to see if the translation works. |
This uses json translations through the blade directive to allow easy
translations of mail notifications.
In contrast to my previous PR this doesn't change the ResetPassword notification as that can be easily changed with the
toMailUsing()method. It also doesn't use the__()helper so no extra dependencies are introduced.