[5.6] fix pivot timestamp columns without parent#23917
Merged
Merged
Conversation
- check to see if `pivotParent` exists before getting its timestamp columns. - if there is no parent, fallback to the parent `Model` methods. - add tests. 1 for when a parent exists, and 1 for when it doesn't
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation of this PR is to allow
Pivotmodels to be queried and saved just like normalModels.Previously, when trying to save pivot models, an error would be thrown because no
pivotParentexisted on the model.This was due to the
getCreatedAtColumn()andgetUpdatedAtColumn()methods being called. It erred with "Call to a member function getCreatedAtColumn() on null".This PR makes sure we first check if the
pivotParentproperty exists. If it does, we continue to use the pivot parent's methods. However, if it doesn't, we fallback to theModels methods.The tests I've added cover both cases of having a
pivotParentand not having one.