[5.6] Support URLs for custom filesystem drivers #23964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some custom filesystem drivers don’t include URL support at the adapter level, but can be added to the driver through the creation of custom plugins. Applications can detect the plugin, but the Filesystem framework currently neglects to check for the ‘getUrl’ method on the driver level.
|
Would it make sense to add a test to make sure this functionality isn't removed in the future? Or perhaps add an interface for the getUrl functionality that we look for? |
|
I think it would make sense. I'm struggling to conceptualise how to add test coverage in practice though. Any thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some custom filesystem drivers don’t include URL support at the adapter level, but can be added to the driver through the creation of custom Flysystem plugins. Applications can detect the plugin, but the Filesystem framework currently neglects to check for the ‘getUrl’ method on the driver level.
For example, I have created a plugin for the Microsoft Azure driver which adds URL support, but at present cannot be used with this framework due to this small omission.