[5.6] Render the right view when using Mailables for sending mails just in plain text format #23981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czmole
changed the title
tillkruss
changed the title
|
This looks like something that could use some tests. |
|
I am very new to this, will try to find a way to cover that. |
|
I've fixed your code duplication for you. |
|
You can find the existing tests for the Mailer class in https://github.com/laravel/framework/blob/5.6/tests/Mail/MailMailerTest.php. Copy the one that is closest match to your scenario, and modify it to test your new functionality. |
|
Looks pretty straight forward. |
|
Thank you. Will still look into putting a test for this, continuous learning :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to fix the case from ticket #23822 and probably #1058
When using Mailables to send e-mails just in plain text format, it was being sent to render only the HTML view. With this change, it will check first if the HTML is present, if not it will send to render the plain text view.
Apologies if this is very straight forward, this is my first PR to Laravel, even if I am using it for about 4 years.