New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Add allowed ip's or networks to Maintenance Mode #24003

Merged
merged 1 commit into from May 2, 2018

Conversation

Projects
None yet
6 participants
@cesargb
Contributor

cesargb commented Apr 25, 2018

With this PR I can access to the App in maintenance mode from certain ip address or networks.

Example:

php artisan down --allow=127.0.0.1 --allow=192.168.0.0/16
@browner12

This comment has been minimized.

Show comment
Hide comment
@browner12

browner12 Apr 25, 2018

Contributor

Can you explain your use case? When is your App going into maintenance mode, and what do you need to see on your production app when it's in maintenance mode?

Contributor

browner12 commented Apr 25, 2018

Can you explain your use case? When is your App going into maintenance mode, and what do you need to see on your production app when it's in maintenance mode?

@m1kfb

This comment has been minimized.

Show comment
Hide comment
@m1kfb

m1kfb Apr 25, 2018

Fixing Data issues in production would be one use case, would be particularly useful for e-commerce instances changing promotional content.

m1kfb commented Apr 25, 2018

Fixing Data issues in production would be one use case, would be particularly useful for e-commerce instances changing promotional content.

@browner12

This comment has been minimized.

Show comment
Hide comment
@browner12

browner12 Apr 25, 2018

Contributor

ahh, so you're thinking like an https://apple.com shutting down its store when it adds new products?

Contributor

browner12 commented Apr 25, 2018

ahh, so you're thinking like an https://apple.com shutting down its store when it adds new products?

@m1kfb

This comment has been minimized.

Show comment
Hide comment
@m1kfb

m1kfb Apr 25, 2018

Yeah, you and sort out product layouts, banners etc... without displaying to customers till it's ready. I don't currently require this functionality myself but could see it being useful.

m1kfb commented Apr 25, 2018

Yeah, you and sort out product layouts, banners etc... without displaying to customers till it's ready. I don't currently require this functionality myself but could see it being useful.

@tillkruss tillkruss changed the title from Add allowed ip's or networks to Maintenance Mode to [5.6] Add allowed ip's or networks to Maintenance Mode Apr 25, 2018

@BrandonShar

This comment has been minimized.

Show comment
Hide comment
@BrandonShar

BrandonShar Apr 25, 2018

Contributor

Nice idea. I always whitelist my own IP when I take a production site down. It's nice to be able to have a look around before turning everything back on.

Contributor

BrandonShar commented Apr 25, 2018

Nice idea. I always whitelist my own IP when I take a production site down. It's nice to be able to have a look around before turning everything back on.

@taylorotwell taylorotwell merged commit 7d9f9c7 into laravel:5.6 May 2, 2018

1 of 2 checks passed

continuous-integration/styleci/pr Issues have been identified with 1 file
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jagdeepsingh-ucreate

This comment has been minimized.

Show comment
Hide comment
@jagdeepsingh-ucreate

jagdeepsingh-ucreate May 7, 2018

This feature (probably) allows for validating the changes (something on the lines of a "build checklist") on the live environment, before pulling down the maintenance shield (and, hopefully, allows triggering a rollback mechanism if any check fails from the build checklist).

jagdeepsingh-ucreate commented May 7, 2018

This feature (probably) allows for validating the changes (something on the lines of a "build checklist") on the live environment, before pulling down the maintenance shield (and, hopefully, allows triggering a rollback mechanism if any check fails from the build checklist).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment