Skip to content

[5.6] Add allowed ip's or networks to Maintenance Mode - #24003

Merged
taylorotwell merged 1 commit into
laravel:5.6from
cesargb:5.6
May 2, 2018
Merged

[5.6] Add allowed ip's or networks to Maintenance Mode#24003
taylorotwell merged 1 commit into
laravel:5.6from
cesargb:5.6

Conversation

@cesargb

@cesargb cesargb commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

With this PR I can access to the App in maintenance mode from certain ip address or networks.

Example:

php artisan down --allow=127.0.0.1 --allow=192.168.0.0/16

@browner12

Copy link
Copy Markdown
Contributor

Can you explain your use case? When is your App going into maintenance mode, and what do you need to see on your production app when it's in maintenance mode?

@m1kfb

m1kfb commented Apr 25, 2018

Copy link
Copy Markdown

Fixing Data issues in production would be one use case, would be particularly useful for e-commerce instances changing promotional content.

@browner12

Copy link
Copy Markdown
Contributor

ahh, so you're thinking like an https://apple.com shutting down its store when it adds new products?

@m1kfb

m1kfb commented Apr 25, 2018

Copy link
Copy Markdown

Yeah, you and sort out product layouts, banners etc... without displaying to customers till it's ready. I don't currently require this functionality myself but could see it being useful.

@tillkruss tillkruss changed the title Add allowed ip's or networks to Maintenance Mode [5.6] Add allowed ip's or networks to Maintenance Mode Apr 25, 2018
@BrandonShar

Copy link
Copy Markdown
Contributor

Nice idea. I always whitelist my own IP when I take a production site down. It's nice to be able to have a look around before turning everything back on.

@jdecode

jdecode commented May 7, 2018

Copy link
Copy Markdown

This feature (probably) allows for validating the changes (something on the lines of a "build checklist") on the live environment, before pulling down the maintenance shield (and, hopefully, allows triggering a rollback mechanism if any check fails from the build checklist).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants