[5.6] Add new comparison validation rules #24091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These will need new language lines in the laravel/laravel repository. Thanks. |
|
why are we using shortened names for this? Why not 'greaterThan' instead of 'gt', just like all the other rules? seems very unintuitive, and unlike everything else we see in the framework. |
TBlindaruk
added a commit
to TBlindaruk/laravel-docs
that referenced
this pull request
May 13, 2018
It is a rule from laravel/framework#24091 PR
|
@Alymosul , Could you please create a PR for docs repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified #23807 to handle 'equals to' and support passing of integers, note that i only allow passing of integers only when the field under comparison is of the integer type