[5.6] Fix dateBasedWhere() with raw expressions in SQLite #24102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whereDate()
,whereMonth()
etc. don't work with raw expressions in SQLite:This line causes the problem:
framework/src/Illuminate/Database/Query/Grammars/SQLiteGrammar.php
Line 141 in 4306de8
The code looks like it pads days/months from
1
to01
when callingwhereDay()
/whereMonth()
.But since the value is added to the bindings before this is called, it has no effect. In the next line
$this->parameter()
replaces it with the placeholder?
.This PR adds raw expression tests for all databases and also missing
whereDate()
tests.