Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Fix: If the expiration is null, set it permanently when increments in file cache driver #24228

Merged
merged 1 commit into from
May 16, 2018

Conversation

eddiclin
Copy link
Contributor

I meet a bug when using increment of file cache driver.

Reproduce

Use file cache driver, config it in the .env

CACHE_DRIVER=file
Cache::increment('key');    // return 1
Cache::increment('key');    // ERROR: return 1

Fix

If the expiration is null, set it permanently when increments.

After fix:

Cache::increment('key');    // return 1
Cache::increment('key');    // return 2

@eddiclin eddiclin changed the title If the expiration is null, set it permanently when increments in file cache driver [5.6] Fix: If the expiration is null, set it permanently when increments in file cache driver May 16, 2018
@taylorotwell taylorotwell merged commit 0b83cc1 into laravel:5.6 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants