Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Added assertUri method to TestReponse #24267

Merged
merged 2 commits into from
May 21, 2018
Merged

[5.6] Added assertUri method to TestReponse #24267

merged 2 commits into from
May 21, 2018

Conversation

gsingh1
Copy link
Contributor

@gsingh1 gsingh1 commented May 21, 2018

This PR is to add a simple helper to facilitate the checking of the TestResponse URI to ensure that in a test, when doing a request, the TestResponse correctly goes to an expectant URI.

Example:
$response->assertUri($uri);
instead of
$response->assertHeader('Location', $uri);

@taylorotwell taylorotwell merged commit 378ca9d into laravel:5.6 May 21, 2018
@gsingh1
Copy link
Contributor Author

gsingh1 commented May 21, 2018

This would be great to have in the 5.5 branch too. How can I request this?
@taylorotwell
Thanks

@antonkomarev
Copy link
Contributor

Maybe it was better to name it assertLocation?

@gsingh1
Copy link
Contributor Author

gsingh1 commented May 21, 2018

Already done - see here

@antonkomarev
Copy link
Contributor

Great, thanks. It will be much more clear now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants