Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[5.6] Extract setting mutated attribute into method #24307
When dealing with accessors, code looks like now like this:
so in case of custom method functionality, it's possible to override both hasGetMutator and mutateAttribute for custom code.
But for mutator code looked so far like this:
so it's impossible to do similar change for mutator. In fact you need to override the whole setAttribute method just to make similar change because setting mutated attribute is not extracted to external method.
After this PR code for mutator condition would look like this:
so now it would be enough just to override those 2 methods instead of touching setAttribute code. Also code is more consistent now I believe.