[5.6] Add Builder::whereJsonNotContains()

[staudenmeir]

Adds whereJsonNotContains() to complement whereJsonContains() (#24330).

Or would you prefer whereJsonDoesntContain()?

EDIT: This isn't a breaking change because whereJsonContains() hasn't been released yet.

[sisve]

You're changing the method signature of whereJsonContains which is a breaking change. This indicates that the PR should target the master branch (the next release).

[staudenmeir]

whereJsonContains() hasn't been released yet.

[sisve]

Ah, but I wouldn't admit to being wrong. But I was perhaps not fully correct. ;)

You're right, this wouldn't be a breaking change since it isn't released yet.

[staudenmeir]

I wasn't implying that ;-) I should have mentioned it in the first post.

[cirdog]

Why not just let users use "whereIn" & "whereNotIn" on the surface and internally call "whereJsonContains" & "whereJsonNotContains" under the hood whenever the column name contains the "->" syntax?

It's more concise & unified as I myself treat the Query Builder as a "programming interface" of some sort.

[staudenmeir]

There are two reasons:

• whereIn() is the opposite of whereJsonContains():
  whereIn() checks whether the column value exists in the values provided by the user.
  whereJsonContains() checks whether the value provided by the user exists in the column.
• When the column value is an array, the column selector wouldn't contain a ->.
  So Laravel wouldn't know that the user is querying a JSON column.