[5.6] Make ResetPassword Notification translateable

[dimitri-koenig]

Instead of doing funky stuff like this (https://laracasts.com/discuss/channels/laravel/how-to-language-for-illuminateauthnotificationsresetpasswordphp) it would be so nice to just be able to translate the messages in the password reset mail like everything else, kinda like a no brainer :-)

[GrahamCampbell]

This introduces cross-dependency on the foundation namespaces, which breaks installing the auth package stand-alone.

[dimitri-koenig]

Laravel is all about making life for developers easier. The current way of not being able to translate such strings is a perfect target to make lifer easier.

Any other idea on how to achieve that?

[devcircus]

One way laravel makes life easy, is making it so the developer can deviate from the convention when they need to. Overriding a method in a trait in order to specify your own notification, is not "funky" or a hack. It is made this way so you can use your own notification. It's even in the documentation:

Reset Email Customization
You may easily modify the notification class used to send the password reset link to the user. To get started, override the sendPasswordResetNotification method on your User model. Within this method, you may send the notification using any notification class you choose. The password reset $token is the first argument received by the method.

Otherwise, the '__' helper method depends on Illuminate\Foundation. So to drop that requirement, you'd need to handle the translation without the helper method.

[dimitri-koenig]

I get the point about being able to customize the notification. But technically it's not about customizing the notification but about finishing the translation process. Per default laravel ships with resources/lang/en/* files which handle most of the auth translations. Even the auth views are done in such a way that an easy and fast translation of labels is possible without touching those view files. But it's like 80% done. The reset password notification is missing. Now I would like to finish it. So, any other idea's are very welcome.

[devcircus]

10-4 just do it without the foundation helper method.

[dimitri-koenig]

@devcircus Any idea how without writing code to make translations?

On a quick glance Auth namespace is dependent on Notifications namespace.
Support namespace is dependent on Notifications namespace.
Foundation namespace is dependent on Notifications namespace.
Auth namespace is already dependent on Support namespace.
Session namespace is also dependent on Support namespace.

So we have a bunch of dependencies. Why then is it so important to not add another dependency to the Foundation namespace?

[dimitri-koenig]

What about adding a local translate method which does the same as the __ foundation method? Would be dependent on the Translation namespace, but in light of many other namespace cross dependencies all around laravel it would be ok, imho. Any thoughts on this?

[devcircus]

Foundation is not a standalone package that can be pulled into a project that is using Auth. You would have to include the entire framework. Foundation exists simply to glue the framework together with the other components.

I haven't looked deep into it, but couldn't you just use the Lang facade. The rest of the framework uses facades occasionally and it is in the Illuminate\Support namespace, which is already required by the Auth component.

[dimitri-koenig]

Thanks for the tip. I've updated the commit accordingly, now it uses actually the same code as the __ method, just via the Lang facade.

[dimitri-koenig]

Perfect, thx

[dakira]

@dimitri-koenig wow. This is great. I tried to get this into the framework in the past and couldn't move on for the same reasons. I'm confused, though. The facade needs Illuminate/Translation/Translator which is a dependency in neither Support nor Auth. So the way I see it this would just break if Illuminate/Translation is not present, right? OTOH illuminate/notification is also not a required dependency, how is that handled? Maybe @GrahamCampbell could help me understand?