Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Use input method to allow compatibility with Lumen and PusherBroadcaster #24622

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

davidstanley01
Copy link
Contributor

When using Lumen, the route resolver as called in \Illuminate\Http\Request::route will generally return an array and not a \Illuminate\Routing\Route object. This presents a problem whenever the __get magic method on the Request object is called.

In \Illuminate\Broadcasting\Broadcasters\PusherBroadcaster::decodePusherResponse, the first conditional uses that magic method to check if a callback is present. This change was introduced in #24018 and is the root cause of this issue.

To resolve this issue, we should use the input method to check for a callback rather than the current style. The change introduced here does just that and will fix laravel/lumen-framework#763.

@GrahamCampbell GrahamCampbell changed the title Use input method to allow compatibility with Lumen and PusherBroadcaster [5.6] Use input method to allow compatibility with Lumen and PusherBroadcaster Jun 18, 2018
@deleugpn
Copy link
Contributor

Would this be a good candidate for tests to avoid regression?

@taylorotwell taylorotwell merged commit 71a4c8e into laravel:5.6 Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants