Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Passes token configuration value to AWS Client #24746

Merged
merged 2 commits into from
Jul 4, 2018
Merged

[5.6] Passes token configuration value to AWS Client #24746

merged 2 commits into from
Jul 4, 2018

Conversation

shrink
Copy link
Contributor

@shrink shrink commented Jul 4, 2018

The AWS client accepts a token configuration value alongside key and secret. This value is optional in most cases but it is required when accessing AWS in some environments, e.g: Lambda. At present the Laravel S3 storage driver and the Laravel SQS connector cannot be used from within a Lambda function because this value is not passed through.

Via AwsClient:

     * - credentials:
     *   (Aws\Credentials\CredentialsInterface|array|bool|callable) Specifies
     *   the credentials used to sign requests. Provide an
     *   Aws\Credentials\CredentialsInterface object, an associative array of
     *   "key", "secret", and an optional "token" key, `false` to use null
     *   credentials, or a callable credentials provider used to create
     *   credentials or return null. See Aws\Credentials\CredentialProvider for
     *   a list of built-in credentials providers. If no credentials are
     *   provided, the SDK will attempt to load them from the environment.

This was already fixed for the for the mail manager in #23766

This PR fixes it for the S3 driver and the SQS connector which are the remaining AWS integrations in laravel/framework.

@shrink shrink changed the title Passes token configuration value to AWS Client [5.6] Passes token configuration value to AWS Client Jul 4, 2018
@taylorotwell taylorotwell merged commit bbe8950 into laravel:5.6 Jul 4, 2018
@shrink shrink deleted the patch-1 branch January 29, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants