[5.6] Passing parameters to Grouped Middleware(s) on Routes middleware setup#25048
Closed
isocroft wants to merge 7 commits intolaravel:5.6from
Closed
[5.6] Passing parameters to Grouped Middleware(s) on Routes middleware setup#25048isocroft wants to merge 7 commits intolaravel:5.6from
isocroft wants to merge 7 commits intolaravel:5.6from
Conversation
|
Nice work @isocroft |
Collaborator
|
Thanks for the PR. Any chance you could add some tests so that it's clear what the code does to future readers, and to ensure it doesn't get broken in the future? |
Member
|
No plans to add this right now. Code is kinda gnarly. |
Author
|
@GrahamCampbell I'll be sure to add tests to the PR for proper scrutiny ASAP. Perhaps, I and @taylorotwell could work on this later on with a less challenging context to it. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, so i work for @synergixe and we had some problem reference by issue #24668 and we had to use a workaround (please see workaround code in issue referenced) which my company posted on that issue. This is a pull request that makes it easier to do the below and have all group middlewares receive the same parameters automatically.
This will make the life of an average Laravel developer a lot easier going forward. Thanks