[5.6] Fix URL validation pattern #25194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlanvin
added a commit
to rlanvin/framework
that referenced
this pull request
Feb 20, 2019
Backport of laravel#25194.
This was referenced Feb 20, 2019
|
Happens the same whit Laravel 5.4 + PHP 7.3. I think that it will be useful for someone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the Laravel tests with PHP 7.3.0beta1 on Windows,
testValidateUrlWithValidUrls()fails with an exception:The hyphen has to be escaped:
https://stackoverflow.com/q/26208622/4848587
https://stackoverflow.com/q/24764212/4848587
Apparently, this pattern has always been invalid, PHP just never complained.
This is the Symfony fix (where the pattern is from): symfony/validator@ea91e49