[5.6] logoutOtherDevices breaks "remember me" cookie #25386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolivir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current issue:
Before this PR the remember me cookie would break when the user used the function
logoutOtherDevices(). See issue #24857logoutOtherDevices()changes the password hash. Now we have a mismatch because the new password hash is not the same as the one saved in the "remember me" cookie.Fixes:
After the forceFill of the user with the new hashed password, the method
queueRecallerCookie()now gets called to generate/set a new cookie so the current user can be authenticated with the cookie if the session expires.Cheers