[5.7] Do not send email verification if user is already verified #25450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey guys, So I'm using Socialite to register users. I'm dispatching the Registered event and since my model now extends MustVerifyEmail, it sends out an email to users which are already verified (force filled by my FB/Google integration). This makes sure that a "verified" user does not receive the email, so if in your registration process you mark them as verified, they will not receive the email.
|
No tests? |
|
@sisve There are no tests regarding email verification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
So I'm using Socialite to register users. I'm dispatching the Registered event and since my model now extends MustVerifyEmail, it sends out an email to users which are already verified (force filled by my FB/Google integration).
This makes sure that a "verified" user does not receive the email, so if in your registration process you mark them as verified, they will not receive the email.