[5.7] Make any column searchable with like in PostgreSQL (and fix Global Search in Laravel Nova)
#25698
Conversation
|
This new feature definitely needs tests. |
|
Yes, it requires tests. Just added assertions on grammar with |
|
The pull request targets Laravel 5.7, but since Nova works with Laravel 5.6 too, would it make sense to fix it in 5.6 too? |
| return $this->whereBasicLike($query, $where); | ||
| } | ||
|
|
||
| $value = $this->parameter($where['value']); |
There was a problem hiding this comment.
You can use return parent::whereBasic($query, $where);.
There was a problem hiding this comment.
If this is the case there is no point in overwriting the method at all.
There was a problem hiding this comment.
How do you mean? I meant that the lines 40 and 42 do exactly what the parent method does.
There was a problem hiding this comment.
Sorry, you pointed the wrong lines, forget what I said you are right.
There was a problem hiding this comment.
My comment points to line 40, but GitHub also shows the previous lines.
There was a problem hiding this comment.
Changed to parent call.
| { | ||
| // Special treatment for like clauses. In order to make | ||
| // any column searchable, we need to convert it to text. | ||
| if (Str::contains($where['operator'], 'like')) { |
There was a problem hiding this comment.
strtolower($where['operator']) to handle uppercase LIKE.
There was a problem hiding this comment.
implemented and added an extra assertion for this case
| /** | ||
| * {@inheritdoc} | ||
| * | ||
| * @param Builder $query |
There was a problem hiding this comment.
The PHPDoc of both methods is incorrect, take a look at whereDate().
There was a problem hiding this comment.
Updated the docs, are they ok this way?
|
That’s right, after the if condition it does the same as the parent method.
I’ll add the parent call when I’m back at my laptop...
…--- edit:
rm unnecessary content
|
|
A request has been made to fix this in Laravel 5.6 too (see here). Will this get merged to 5.6 or should I close this PR and open a new one with a fix for 5.6? |
GrahamCampbell
changed the title
like in PostgreSQL (and fix Global Search in Laravel Nova)like in PostgreSQL (and fix Global Search in Laravel Nova)
|
Thanks for merging! \o/ |
This small change actually became necessary to make Global Search in Laravel Nova on PostgreSQL possible.
See related issue here: laravel/nova-issues#46
Postgres doesn't like to compare non text fields using like without strict type conversion, so we need to add it.