Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Use the model connection #26148

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Conversation

shadoWalker89
Copy link
Contributor

This merged PR #26133 allows the following method assertSoftDeleted() to make an assertion using a model.

Since it is making the assertion using the model, the model database connection should also be used in the assertion so we do not need to do this when the model has a database connection other then the default one

// Avoid this, by passing the model connection
$this->assertSoftDeleted($model, [], 'customConnection');

@taylorotwell taylorotwell merged commit 951a12f into laravel:5.7 Oct 18, 2018
@shadoWalker89 shadoWalker89 deleted the patch-1 branch October 18, 2018 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants