[5.7] Fix filesystem locking hangs in PackageManifest::build() (#25898) #26254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Filesystem.php
1. Created a new `Filesystem::replace()` method that atomically
replaces a file if it already exists.
- PackageManifest.php
1. The Filesystem::get() call in PackageManifest::getManifest() no
longer has to use an exclusive lock because the packages.php
manifest file will always be replaced atomically.
2. Use the new Filesystem::replace() method in
PackageManifest::write()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, for what it's worth, here is my updated fix for #25898, the NFS file locking issue.
I cleaned it up some more and included a fix that prevents #26232. I also included that case in the unit test, among with some other cases.
Filesystem.php
Filesystem::replace()method that atomically replaces a file if it already exists.PackageManifest.php
The Filesystem::get() call in PackageManifest::getManifest() no longer has to use an exclusive lock because the packages.php manifest file will always be replaced atomically.
Use the new Filesystem::replace() method in PackageManifest::write()